Fix I2S crackling in 2.x #8583
Merged
Fix I2S crackling in 2.x #8583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason2866
referenced
this pull request
in tasmota/esp-idf
Aug 29, 2023
1 task
me-no-dev
pushed a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Commit espressif/esp-idf@73ca054 introduced crackling in the I2S communication (as discussed in #8467). This PR aims to revert the changes by replacing the
libdriver.afile for each board with one the reverted changes.Each
libdriver.afile was generated by the following steps:1 - Cloned ESP-IDF and checked out commit in
versions.txt;2 - Added Arduino as an ESP-IDF component and checked out commit in
versions.txt;3 - Reverted commit espressif/esp-idf@73ca054 in IDF;
4 - Copied
tools/sdk/<CHIP>/sdkconfigto IDF project folder;5 - Compiled using
idf.py build;6 - Copied
<PROJECT_FOLDER>/build/esp-idf/driver/libdriver.atotools/sdk/<CHIP>/lib/libdriver.a.NOTE: The original IDF commit was made to fix I2S microphones. Reverting it might break I2S microphones in Arduino.
Tests scenarios
Tested by @harbaum on ESP32-DevKitC on #8467.
Related links
Closes #8467.