Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idf.py clang-check opens run-clang-tidy.py instead of running it (RDT-244) #16

Closed
xobs opened this issue Jul 22, 2022 · 0 comments · Fixed by #20
Closed

idf.py clang-check opens run-clang-tidy.py instead of running it (RDT-244) #16

xobs opened this issue Jul 22, 2022 · 0 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@xobs
Copy link

xobs commented Jul 22, 2022

On Windows, the command idf.py clang-check opens run-clang-tidy.py instead of running it. This is because it appears to execute the command directly instead of passing it through a Python interpreter.

The documentation at https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/tools/idf-clang-tidy.html does not specify any required platform, and seems to indicate that Windows should be supported.

It correctly runs run-clang-tidy.py if I specify that it should use python to run the script:

idf.py clang-check --run-clang-tidy-py "python $HOME\esp\esp-idf\tools\run-clang-tidy.py"
@github-actions github-actions bot changed the title idf.py clang-check opens run-clang-tidy.py instead of running it idf.py clang-check opens run-clang-tidy.py instead of running it (RDT-244) Jul 22, 2022
@hfudev hfudev self-assigned this Jul 26, 2022
@hfudev hfudev added the bug Something isn't working label Jul 26, 2022
@igrr igrr assigned igrr and unassigned hfudev Aug 25, 2022
igrr added a commit that referenced this issue Sep 8, 2022
@igrr igrr mentioned this issue Sep 8, 2022
@hfudev hfudev closed this as completed in #20 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants