Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TW#26964] Avoid magic numbers in bluetooth/gatt_server example #2622

Closed
ThisNameIsNotAllowed opened this issue Oct 23, 2018 · 1 comment
Closed

[TW#26964] Avoid magic numbers in bluetooth/gatt_server example #2622

ThisNameIsNotAllowed opened this issue Oct 23, 2018 · 1 comment

Comments

@ThisNameIsNotAllowed
Copy link
Contributor

esp-idf/examples/bluetooth/gatt_server/main/gatts_demo.c

Line 110 in 129d327

.service_uuid_len = 32,

as well as

esp-idf/examples/bluetooth/gatt_server/main/gatts_demo.c

Line 126 in 129d327

.service_uuid_len = 32,

Could be replaced by .service_uuid_len = sizeof(adv_service_uuid128), to avoid magic numbers.
@Alvin1Zhang Alvin1Zhang changed the title Avoid magic numbers in bluetooth/gatt_server example [TW#26964] Avoid magic numbers in bluetooth/gatt_server example Oct 24, 2018
@dhrishi
Copy link
Collaborator

dhrishi commented Oct 24, 2018

That's right. Will fix it.

igrr pushed a commit that referenced this issue Nov 18, 2018
@dhrishi
examples/bluetooth: Miscellaneous fixes in some of the examples
55dfb79 
This closes:
#2617
#2622

Signed-off-by: Hrishikesh Dhayagude <hrishi@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhrishi @ThisNameIsNotAllowed @Alvin1Zhang