[TW#27054] esp_http_client issue - Wrong content length set

[AadiMehta]

Environment

• Development Kit: [ESP32-DevKitC]
• Kit version (DevKitC): [v3]
• Core (if using chip or module): [ESP32-Wrover|ESP-WROOM32|ESP32]
• IDF version : 11b444b

Problem Description

esp_http_client_open() API should set "Content-Length" header to the passed size. But the content-length header is either not set or it is set to 0.

I am trying to send a file from esp32 as attachment to a server. Here is the same code for the same.

Code to reproduce this issue

FILE *f = fopen(filename, "r");
   if (f == NULL) {
      ESP_LOGE(TAG, "Failed to open file for sending");
      return -1;
   }

   esp_http_client_handle_t client = esp_http_client_init(&config);

   esp_http_client_set_header(client, "User-Agent", "abc-Node");
   esp_http_client_set_header(client, "Content-Disposition", "attachment; filename=chip.log");
   esp_http_client_set_url(client, url);
   esp_http_client_set_method(client, HTTP_METHOD_POST);

   esp_err_t err;
   if ((err = esp_http_client_open(client, size)) != ESP_OK) {
      ESP_LOGE(TAG, "Failed to open HTTP connection: %s", esp_err_to_name(err));
      free(buffer);
      return -1;
   }

   bzero(buffer, MAX_HTTP_RECV_BUFFER);
   printf("Total size : %d\n", size);

   while ((ret = fread(&buffer[0], sizeof(char), MAX_HTTP_RECV_BUFFER, f)) > 0) {
      esp_http_client_write(client, buffer, ret);
      bzero(buffer, MAX_HTTP_RECV_BUFFER);
   }
   int content_length =  esp_http_client_fetch_headers(client);
   int total_read_len = 0, read_len;
   if (total_read_len < content_length && content_length <= MAX_HTTP_RECV_BUFFER) {
      read_len = esp_http_client_read(client, buffer, content_length);
      if (read_len <= 0) {
         ESP_LOGE(TAG, "Error read data");
      }
      buffer[read_len] = 0;
      ESP_LOGI(TAG, "read_len = %d", read_len);
   }
   ESP_LOGI(TAG, "HTTP Status = %d, content_length = %d",
                       esp_http_client_get_status_code(client),
                       esp_http_client_get_content_length(client));
   esp_http_client_close(client);
   esp_http_client_cleanup(client);
   free(buffer);
   fclose(f);

Debug Logs from server

{
	"CONTENT_LENGTH": "0",
	"SERVER_PROTOCOL": "HTTP/1.1",
	"REQUEST_METHOD": "POST",
	"PATH_INFO": "/logs/api/submit",
	"REMOTE_ADDR": "192.168.2.61",
	"CONTENT_TYPE": "text/plain",
	"HTTP_USER_AGENT": "abc-Node",
	"HTTP_HOST": "192.168.2.16",
	"HTTP_CONTENT_DISPOSITION": "attachment; filename=chip.log",
}

[negativekelvin]

You are right, the value is not used at all. It should do
client->post_len=write_len;

esp-idf/components/esp_http_client/esp_http_client.c

Lines 1085 to 1095 in 3977d4b

	esp_err_t esp_http_client_open(esp_http_client_handle_t client, int write_len)
	{
	esp_err_t err;
	if ((err = esp_http_client_connect(client)) != ESP_OK) {
	return err;
	}
	if ((err = esp_http_client_request_send(client)) != ESP_OK) {
	return err;
	}
	return ESP_OK;
	}

[mahavirj]

Fixed with 2e3f06e, closing.