Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#27381] SPI_CHECK incorrect error message #2690

Closed
michprev opened this issue Nov 11, 2018 · 1 comment
Closed

[TW#27381] SPI_CHECK incorrect error message #2690

michprev opened this issue Nov 11, 2018 · 1 comment

Comments

@michprev
Copy link

  • IDF version (run git describe --tags to find it): v3.1.1-6-g2aa9a2118

Problem Description

SPI_CHECK( dev_config->flags & SPI_DEVICE_HALFDUPLEX || dummy_required == 0 ||
dev_config->flags & SPI_DEVICE_NO_DUMMY,
"When GPIO matrix is used in full-duplex mode at frequency > %.1fMHz, device cannot read correct data.\n\
Please note the SPI can only work at divisors of 80MHz, and the driver always tries to find the closest frequency to your configuration.\n\
Specify ``SPI_DEVICE_NO_DUMMY`` to ignore this checking. Then you can output data at higher speed, or read data at your own risk.",
ESP_ERR_INVALID_ARG, freq_limit/1000./1000 );

The error message talks only about situation when using SPI via GPIO matrix but the assert fails even when using SPI via native pins (which is correct).

The error message should be changed:
When GPIO matrix is used in full-duplex ... -> When SPI is used in full-duplex ...

@Alvin1Zhang Alvin1Zhang changed the title SPI_CHECK incorrect error message [TW#27381] SPI_CHECK incorrect error message Nov 12, 2018
@ginkgm
Copy link
Collaborator

ginkgm commented Nov 13, 2018

Hi @michprev ,
thanks for your suggestions for the error message. due to histroical reason, we thought there's no reading problem with IOMUX but actually this is triggered if the MISO delay is long even with IOMUX.

We will improve this but not backporting this to earlier version.

@igrr igrr closed this as completed in a52ab8c Nov 20, 2018
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this issue May 5, 2021
Implemented the ability to change the ESP32s BLE device address as
according the the BLE specification. This address is used when
advertising the ESP32 over BLE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants