fix: memalign: respect malloc_alwaysinternal_limit (IDFGH-11209)
#12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Welcome codysch, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
|
github-actions
bot
changed the title
malloc_alwaysinternal_limitmalloc_alwaysinternal_limit (IDFGH-11209)
This changes `memalign` (and `posix_memalign`) so that it uses an allocation method with the same selection criteria (checking `malloc_alwaysinternal_limit` and picking one of: - always MALLOC_CAP_INTERNAL - MALLOC_CAP_INTERNAL first with fallback - MALLOC_CAP_SPIRAM first with fallback `malloc_alwaysinternal_limit` is in turn set by the options `CONFIG_SPIRAM_MALLOC_ALWAYSINTERNAL` and `CONFIG_SPRIAM_USE_CAPS_ALLOC`. This notably affects folks using esp-rs to build rust code for the esp-idf, as all allocations from rust use `memalign`.
codysch
force-pushed
the
memalign-internal-external-as-malloc
branch
from
f3af259
to
9424d21
Compare
codysch
changed the title
malloc_alwaysinternal_limit (IDFGH-11209)malloc_alwaysinternal_limit (IDFGH-11209)
espressif-bot
added
Status: Selected for Development
espressif-bot
added
Status: Reviewing
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
This changes `memalign` (and `posix_memalign`) so that it uses an allocation method with the same selection criteria (checking `malloc_alwaysinternal_limit` and picking one of: - always MALLOC_CAP_INTERNAL - MALLOC_CAP_INTERNAL first with fallback - MALLOC_CAP_SPIRAM first with fallback `malloc_alwaysinternal_limit` is in turn set by the options `CONFIG_SPIRAM_MALLOC_ALWAYSINTERNAL` and `CONFIG_SPRIAM_USE_CAPS_ALLOC`. This notably affects folks using esp-rs to build rust code for the esp-idf, as all allocations from rust use `memalign`. Merges #12375
|
Thanks for contribution again, changes merged with 9e1e245. |
movsb
pushed a commit
to movsb/esp-idf
that referenced
this pull request
Dec 1, 2023
This changes `memalign` (and `posix_memalign`) so that it uses an allocation method with the same selection criteria (checking `malloc_alwaysinternal_limit` and picking one of: - always MALLOC_CAP_INTERNAL - MALLOC_CAP_INTERNAL first with fallback - MALLOC_CAP_SPIRAM first with fallback `malloc_alwaysinternal_limit` is in turn set by the options `CONFIG_SPIRAM_MALLOC_ALWAYSINTERNAL` and `CONFIG_SPRIAM_USE_CAPS_ALLOC`. This notably affects folks using esp-rs to build rust code for the esp-idf, as all allocations from rust use `memalign`. Merges espressif#12375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
memalign(andposix_memalign) so that it uses an allocation method with the same selection criteria (checkingmalloc_alwaysinternal_limitand picking one of:malloc_alwaysinternal_limitis in turn set by the optionsCONFIG_SPIRAM_MALLOC_ALWAYSINTERNALandCONFIG_SPRIAM_USE_CAPS_ALLOC.This notably affects folks using esp-rs to build rust code for the esp-idf, as all allocations from rust use
memalign.