-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esp_common): Add ESP_EXIT_ON_ERROR and ESP_EXIT_ON_FALSE macros (IDFGH-12532) #13536
Conversation
👋 Hello DCSBL, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi @DCSBL! |
Awesome 👍 |
… void function Merges: #13536
Thanks for contribution again, changes have been merged with 69f6170. |
In our projects, we often use the
ESP_RETURN_ON_*
macros quite often. However, when the function itself returns void, we encounter limitations in using these macros.While testing a variant of
ESP_EXIT_ON_ERROR
, I came across this commit, which suggests that this method was planned. I'm unsure why it didn't make it into the actual code.Feel free to consider this as a suggestion. If, for some reason, it's not accepted, I'm happy to just use a custom header for our projects.