Additional Fix for Windows 10 IO-Error in make monitor #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @FredrikFornstad , we missed that spot the first time! Now this is needed in two places I'd prefer to do a little refactoring here, maybe add a _persistent_write(self, data) method to the ANSIColorConverter class and call that from the two places. Is that change you'd be interested in making to this PR? |
|
Fully understand that you prefer a nicer solution. Honestly think it is better if you do the refactoring as I think the result will be better then. I totally new to esp-idf... |
espressif-bot
pushed a commit
to espressif/esp-idf-monitor
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the fix provided to #1136 do not cover all situations: There is another write output in idf_monitor.py that also can go wrong... When running the factory lws app, it seems to trigger this one.
How to reproduce:
Compile and flash https://github.com/warmcat/lws-esp32-factory
Run make monitor, access esp32 with web browser, select an AP, enter password
make monitor (on Windows 10) will now crash within 40 seconds but normally just after 5-10 seconds. Refering to IO-Error at row 588.
Proposal for fix:
In my pull request, I have duplicated the fix (second try to write if first one fail) that was introduced to the other write statement in idf_monitor.py as the original solution to issue 1136.
Testing:
After applying my fix and have had it running for 30 minutes, I have had no crash,