Update rmt.c - Fixes exceptions LoadProhibited in RMT driver #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes exceptions LoadProhibited, when rmt tries read variable p_rmt on RX END which can be 0. It happens after esp_reset() (OTA) and the rmt is not probably stopped by it. In other words the routine rmt_driver_isr_default was called before second rx channel was registered. scenario: register tx channel register rx channel reboot register tx channel -> exception (because rx channel is accessed)
jedi7
changed the title
costaud
approved these changes
Mar 29, 2018
|
Hi @jedi7 , Thanks for sending this fix. I've cherry-picked it into our review & merge queue. Angus |
igrr
pushed a commit
that referenced
this pull request
Apr 11, 2018
Fixes exceptions LoadProhibited, when rmt tries read variable p_rmt on RX END which can be 0. It happens after esp_reset() (OTA) and the rmt is not probably stopped by it. In other words the routine rmt_driver_isr_default was called before second rx channel was registered. scenario: register tx channel register rx channel reboot register tx channel -> exception (because rx channel is accessed) Merges #1671
|
Cherry-picked and merged in 3d89c8b. |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
* Selective compilation * Optimized component.mk * Autoconnect WiFi now forces WiFi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exceptions LoadProhibited, when rmt tries read variable p_rmt on RX END which can be 0.
It happens after esp_reset() (OTA) and the rmt is not probably stopped by it.
In other words the routine rmt_driver_isr_default was called before second rx channel was registered.
scenario:
register tx channel
register rx channel
reboot
register tx channel
-> exception (because rx channel is accessed)