-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset COMPONENT_ADD_INCLUDEDIRS in cxx component #1956
Closed
paulreimer
wants to merge
3
commits into
espressif:master
from
paulreimer:add-empty-include-dirs-for-cxx-component
Closed
Unset COMPONENT_ADD_INCLUDEDIRS in cxx component #1956
paulreimer
wants to merge
3
commits into
espressif:master
from
paulreimer:add-empty-include-dirs-for-cxx-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-include-dirs warning
…x component to fix C++ -Wmissing-declarations warning
Also added declarations for Example warning:
|
FYI with this PR, I am now able to compile all C++ within esp-idf (and my app code) with
which is pretty nice! |
Very nice, Paul! We should add some of these to our CI builds as well. |
…ent to fix C++ -Wmissing-declarations warning
igrr
pushed a commit
that referenced
this pull request
Jun 5, 2018
…-include-dirs warning Merges #1956
igrr
pushed a commit
that referenced
this pull request
Jun 5, 2018
…x component to fix C++ -Wmissing-declarations warning Merges #1956
igrr
pushed a commit
that referenced
this pull request
Jun 5, 2018
…ent to fix C++ -Wmissing-declarations warning Merges #1956
These commits have been cherry-picked, thanks @paulreimer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix C++ warning from
-Wmissing-include-dirs
Example warning, with
-Wmissing-include-dirs
but before this patch: