Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example/wifi/scan: fix README grammar (IDFGH-1400) #3678

Closed
wants to merge 2 commits into from
Closed

example/wifi/scan: fix README grammar (IDFGH-1400) #3678

wants to merge 2 commits into from

Conversation

fakefred
Copy link
Contributor

example/wifi/scan/README.md is currently holding grammatical imperfections. This pull request improves this document.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2019

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title example/wifi/scan: fix README grammar example/wifi/scan: fix README grammar (IDFGH-1400) Jun 22, 2019
Copy link
Collaborator

@krzychb krzychb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fakefred this is very nice update.
Please see some comments.
Thank you for contribution!

examples/wifi/scan/README.md Outdated Show resolved Hide resolved
examples/wifi/scan/README.md Outdated Show resolved Hide resolved
@fakefred
Copy link
Contributor Author

Okay, I think I fixed it.

@krzychb krzychb self-assigned this Jun 26, 2019
@krzychb
Copy link
Collaborator

krzychb commented Jun 27, 2019

Hi @fakefred, I have added this PR to internal review queue, thanks!

@liuzfesp
Copy link
Contributor

Looks good to me! Thanks @fakefred for your effort!

igrr pushed a commit that referenced this pull request Jul 3, 2019
@krzychb
Copy link
Collaborator

krzychb commented Jul 4, 2019

Merged in d1ceaf8, thanks @fakefred!

@krzychb krzychb closed this Jul 4, 2019
trombik pushed a commit to trombik/esp-idf that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants