Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git on macos does not have -C option, use correct option (IDFGH-1809) #4019

Closed
wants to merge 1 commit into from
Closed

Git on macos does not have -C option, use correct option (IDFGH-1809) #4019

wants to merge 1 commit into from

Conversation

X-Ryl669
Copy link
Contributor

@X-Ryl669 X-Ryl669 commented Sep 4, 2019

Fix #4018

@X-Ryl669
Copy link
Contributor Author

X-Ryl669 commented Sep 4, 2019

Your script for JIRA checking is not working. It can't connect to the JIRA server.

@X-Ryl669 X-Ryl669 mentioned this pull request Sep 4, 2019
Closed
@github-actions github-actions bot changed the title Git on macos does not have -C option, use correct option Git on macos does not have -C option, use correct option (IDFGH-1809) Sep 4, 2019
@Alvin1Zhang
Copy link
Collaborator

@X-Ryl669 Thanks for the contributions and kind notes about the Jira. We will look into this PR and also check Jira. Thanks.

igrr pushed a commit that referenced this pull request Sep 30, 2019
@X-Ryl669 @igrr
idf_tools.py: pass --work-tree instead of -C option to git
81ffc87 
Older versions of git do not support -C option. Use --work-tree option
instead.

Closes #4018
Merges #4019
@X-Ryl669 X-Ryl669 closed this Sep 30, 2019
igrr pushed a commit that referenced this pull request Oct 27, 2019
@X-Ryl669 @igrr
idf_tools.py: pass --work-tree instead of -C option to git
3c97f7e 
Older versions of git do not support -C option. Use --work-tree option
instead.

Closes #4018
Merges #4019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to install on mac OS (IDFGH-1808)
2 participants
@X-Ryl669 @Alvin1Zhang