fix(FreeRTOS): Initialize uxTaskNumber at task initialization (IDFGH-1815) #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GautierAtWork Thanks for the contribution, we will look into this PR. Thanks. |
github-actions
bot
changed the title
|
|
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
…#4025) Co-authored-by: lewis he <lewisxhe@outlook.com>
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
Signed-off-by: Laukik Hase <laukik.hase@espressif.com> Closes #4025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uxTaskNumbermember ofstruct tskTaskControlBlockis not initialized at thread creation.As the TCB can be dynamically allocated,
uxTaskNumbermight then get a value from the heap.As a result, the user might get a seems-valid value when calling
uxTaskGetTaskNumber()and then take wrong decisions.This fix zeroes
uxTaskNumberwhen the task is initialized.