Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding option (IDFGH-1905) #4106

Closed
wants to merge 1 commit into from
Closed

Conversation

trickre
Copy link
Contributor

@trickre trickre commented Sep 22, 2019

This commit resolve "UnicodeDecodeError" when idf.py execute.

My Environment:

  • python3.7
  • Windows10 pro
  • Japanese

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title add encoding option add encoding option (IDFGH-1905) Sep 22, 2019
espressif-bot pushed a commit that referenced this pull request Dec 16, 2019
Merges #4106

Signed-off-by: Sergei Silnov <sergei.silnov@espressif.com>
@kumekay
Copy link
Collaborator

kumekay commented May 19, 2020

@trickre Thank you for the PR,
it was merged, with some modifications,
if solution works for you, could you please close the PR?

@Alvin1Zhang
Copy link
Collaborator

@trickre Thanks for contribution, changes merged with 7e5d30c, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants