Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idf.py --resolved before reset option issue (IDFGH-1925) #4125

Closed
wants to merge 3 commits into from
Closed

idf.py --resolved before reset option issue (IDFGH-1925) #4125

wants to merge 3 commits into from

Conversation

mmt-10
Copy link
Contributor

@mmt-10 mmt-10 commented Sep 27, 2019

#4092 (comment)
idf.py ignores menuconfig --> Serial flasher config --> before flashing (No reset) option.
this idf.py is resloved before reset option issue

#4092 (comment)
idf.py ignores menuconfig --> Serial flasher config --> before flashing (No reset) option.
this idf.py is resloved before reset option issue
idf.py --resolved before reset option issue
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title idf.py --resolved before reset option issue idf.py --resolved before reset option issue (IDFGH-1925) Sep 27, 2019
@dobairoland dobairoland self-requested a review September 27, 2019 10:12
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tatsutaigu for your contribution. I would like to ask you squash the commits into one and add a line with "Closes #4092" and "Merges #4125" to the end of the commit message. Thank you!

tools/idf.py Outdated Show resolved Hide resolved
@dobairoland
Copy link
Collaborator

Thank you @tatsutaigu.

@kumekay I think we can squash the commits and add the "Closes" and "Merges" link.

espressif-bot pushed a commit that referenced this pull request Nov 18, 2019
espressif-bot pushed a commit that referenced this pull request Dec 16, 2019
@kumekay
Copy link
Collaborator

kumekay commented May 19, 2020

@tatsutaigu thank you for contribution once again,
your changes were merged, since changes were squashed commit ids has changed, so github didn't handle it automatically, if you are ok with changes, could you please close this PR?

@mmt-10 mmt-10 closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants