-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading CA certs with unsupported extensions (IDFGH-2307) #4445
Support loading CA certs with unsupported extensions (IDFGH-2307) #4445
Conversation
@ryankurte This is not recommended config option per https://github.com/ARMmbed/mbedtls/blob/development/include/mbedtls/config.h#L1875, I wonder if we should expose this through kconfig. Could you please help to elaborate on requirement? (CC @projectgus) |
Hey thanks for the reply, we use name constraints on our internal TLS infrastructure which are unsupported by mbed-tls, leaving us with the option to disable this or to re-issue our infrastructure without name constraints. If y'all don't want it in the kconfig we can just define it globally in our projects, it was however pretty annoying to track down so might make a good addition to the TLS docs somewhere? |
@mahavirj @ryankurte What about adding a "Show configurations with potential security risks" option to the mbedTLS menu that defaults to |
Hi @ryankurte, Yes, something like that! There is a way to do it without moving all these config items under the parent, something like |
@ryankurte Thanks for changes. I will put this up in our internal review queue. |
Hey hi,
This PR adds support for CA certificates with critical extensions unsupported by mbedtls (fixes
esp-tls: mbedtls_x509_crt_parse returned -0x2562
when loading CA certificates with critical Name Constraints).(It's be awesome if it was possible to land this in 4.0 but I wasn't sure what to open the PR against)