Fix standard NEC IR transmission (IDFGH-2676) #4750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMT write should be non-blocking to wait the correct time for sending the repeat frame
fixes standard protocol mode wich would fail due to integer promotion in inversion
|
|
github-actions
bot
changed the title
|
Thanks for the contribution. |
|
Thanks for the contribution. |
|
@Dee-Fuse Thanks for your contributions, we will merge it ASAP. |
DeeFuse
commented
Feb 12, 2020
| @@ -102,10 +102,10 @@ static esp_err_t nec_build_frame(ir_builder_t *builder, uint32_t address, uint32 | |||
| if (!nec_builder->flags & IR_TOOLS_FLAGS_PROTO_EXT) { | |||
| uint8_t low_byte = address & 0xFF; | |||
| uint8_t high_byte = (address >> 8) & 0xFF; | |||
There was a problem hiding this comment.
alternatively invert the variables in here instead of inverting it in the comparision
uint8_t high_byte = (~address >> 8) & 0xFF;Same for the command
espressif-bot
pushed a commit
that referenced
this pull request
Mar 1, 2020
fixes standard protocol mode wich would fail due to integer promotion in inversion Merges #4750
espressif-bot
pushed a commit
that referenced
this pull request
Mar 2, 2020
fixes standard protocol mode wich would fail due to integer promotion in inversion Merges #4750
|
Thanks for your contribution! we have merged this PR. See in c788351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some oversights in the RMT IR example that might break the functionallity of it.
One problem were the blocking RMT writes which elongated the delay between message and repeat frame to increase.
The other issue had to do with integer promotion which prevented the use of the utility in non-extended mode.