Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ble_hid_device_demo: fix build if building with c++ (IDFGH-3182) #5191

Closed
wants to merge 1 commit into from

Conversation

elvisdukaj
Copy link

Fixed missing closing bracket in the header file

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title ble_hid_device_demo: fix build if building with c++ ble_hid_device_demo: fix build if building with c++ (IDFGH-3182) Apr 26, 2020
@elvisdukaj
Copy link
Author

Even if I agreed the CLA it seems something is still wrong....

@elvisdukaj
Copy link
Author

Even if I have signed the CLA still not able to pass the checks. What am I doing wrong?

image

Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Copy link
Contributor

@GYC-Espressif GYC-Espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

igrr pushed a commit that referenced this pull request Jun 12, 2020
Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Signed-off-by: liminyang <liminyang@example.com>

Merges #5191
@Alvin1Zhang
Copy link
Collaborator

Alvin1Zhang commented Jun 30, 2020

Thanks for reporting, please refer to 1463cd3, will close this PR, thanks again.

mahavirj pushed a commit to espressif/esp-afr-sdk that referenced this pull request Jul 16, 2020
Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Signed-off-by: liminyang <liminyang@example.com>

Merges espressif/esp-idf#5191
espressif-bot pushed a commit that referenced this pull request Jul 18, 2020
Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Signed-off-by: liminyang <liminyang@example.com>

Merges #5191
espressif-bot pushed a commit that referenced this pull request Sep 10, 2020
Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Signed-off-by: liminyang <liminyang@example.com>

Merges #5191
espressif-bot pushed a commit that referenced this pull request Sep 29, 2020
Signed-off-by: Elvis Dukaj <elvis.dukaj@gmail.com>
Signed-off-by: liminyang <liminyang@example.com>

Merges #5191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants