Update idf_monitor.py to make --toolchain-prefix argument work #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--toolchain-prefix command line argument was not taken into account when specified
|
|
|
Thanks Henrik, appreciate the fix. This looks like it fixes the --eol argument as well. Have put this into our internal review & merge queue. |
|
I don't have the gcc compiler in the path and depend on the configuration to point to the correct location. This is how I discovered this minor bug. |
igrr
pushed a commit
that referenced
this pull request
May 19, 2017
--toolchain-prefix command line argument was not taken into account when specified Merges #617
espressif-bot
pushed a commit
to espressif/esp-idf-monitor
that referenced
this pull request
Jan 16, 2023
--toolchain-prefix command line argument was not taken into account when specified Merges espressif/esp-idf#617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--toolchain-prefix command line argument was not taken into account when specified