esp_supplicant: Make esp_rrm_send_neighbor_rep_request return proper … (IDFGH-5503) #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error Current code always return 0 even though wpas_rrm_send_neighbor_rep_request() fails. Return proper error so the caller can know what's wrong. Signed-off-by: Axel Lin <axel.lin@gmail.com>
|
Hi @kapilkedawat Without the fix, https://github.com/espressif/esp-idf/blob/master/examples/wifi/roaming/main/roaming_example.c#L316 cannot catch the error. Also note v4.3 also needs the fix. |
|
Hi @AxelLin, Thanks for contributing. This fix is already part of latest IDF code and should be available in github next push. |
github-actions
bot
changed the title
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Aug 11, 2021
…error Current code always return 0 even though wpas_rrm_send_neighbor_rep_request() fails. Return proper error so the caller can know what's wrong. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Sagar Bijwe <sagar@espressif.com> Merges #7233
espressif-bot
pushed a commit
that referenced
this pull request
Aug 15, 2021
…error Current code always return 0 even though wpas_rrm_send_neighbor_rep_request() fails. Return proper error so the caller can know what's wrong. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Sagar Bijwe <sagar@espressif.com> Merges #7233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…error
Current code always return 0 even though wpas_rrm_send_neighbor_rep_request()
fails. Return proper error so the caller can know what's wrong.
Signed-off-by: Axel Lin axel.lin@gmail.com