esp_modem_dce_service: Make esp_modem_dce_handle_* functions static (IDFGH-5542) #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
david-cermak
suggested changes
Jul 23, 2021
There was a problem hiding this comment.
Thanks for this PR. Yes, I think it's a good idea to make the functions for handling replies static.
Could you please just move the doxy comments next to the definitions. Even if it's not a public API, i think it's a good idea to keep the documentation, at least the first @brief line.
These functions are unlikely to be reused, make them static. Take esp_modem_dce_handle_cbc as an example, it's internal implementation of esp_modem_dce_get_battery_status, expose esp_modem_dce_get_battery_status function is enough. Signed-off-by: Axel Lin <axel.lin@gmail.com>
AxelLin
force-pushed
the
esp_modem_dce_service_improve
branch
from
50b58d2
to
fcc96a3
Compare
david-cermak
approved these changes
Jul 26, 2021
espressif-bot
added
Status: In Progress
espressif-bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
…s static These functions are unlikely to be reused, make them static. Take esp_modem_dce_handle_cbc as an example, it's internal implementation of esp_modem_dce_get_battery_status, expose esp_modem_dce_get_battery_status function is enough. Signed-off-by: Axel Lin <axel.lin@gmail.com> Merges #7266
|
Thanks for your contribution, changes have been merged with d6248ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are unlikely to be reused, make them static.
Take esp_modem_dce_handle_cbc as an example, it's internal implementation
of esp_modem_dce_get_battery_status, expose esp_modem_dce_get_battery_status
function is enough.
Signed-off-by: Axel Lin axel.lin@gmail.com