Update projdefs.h (IDFGH-6179) #7856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lose of precision on pdTICKS_TO_MS convertions. (IDFGH-6176) #7853
|
PRs like this are supposed to be made against the master branch. |
Dazza0
suggested changes
Nov 23, 2021
There was a problem hiding this comment.
- Nitpick: Commit message format
freertos: Add higher precision pdTICKS_TO_MS macro
Closes https://github.com/espressif/esp-idf/issues/7853
Closes https://github.com/espressif/esp-idf/pull/7856
@lisekt84 Left a couple of nitpicks but the new macro LGTM.
Dazza0
approved these changes
Nov 25, 2021
espressif-bot
added
Resolution: NA
espressif-bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
Freertos: Fix loss of precision in pdTICKS_TO_MS (GitHub PR #7856) Closes IDFGH-6179 See merge request espressif/esp-idf!16133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lose of precision on pdTICKS_TO_MS convertions. (IDFGH-6176) #7853
This bug is on master and other branches too