Fix: Stop client only if it's running.

euripedesrocha · euripedesrocha · commit 36eec6f62559 · 2023-06-21T09:39:42.000+02:00
Check for client run instead of lock to call esp_mqtt_client_stop
when destroying the client.
diff --git a/mqtt_client.c b/mqtt_client.c
@@ -877,7 +877,7 @@ esp_err_t esp_mqtt_client_destroy(esp_mqtt_client_handle_t client)
     if (client == NULL) {
         return ESP_ERR_INVALID_ARG;
     }
-    if (client->api_lock) {
+    if (client->run) {
         esp_mqtt_client_stop(client);
     }
     esp_mqtt_destroy_config(client);

Original file line number	Diff line number	Diff line change
`@@ -877,7 +877,7 @@ esp_err_t esp_mqtt_client_destroy(esp_mqtt_client_handle_t client)`
`877`	`877`	`if (client == NULL) {`
`878`	`878`	`return ESP_ERR_INVALID_ARG;`
`879`	`879`	`}`
`880`		`- if (client->api_lock) {`
	`880`	`+ if (client->run) {`
`881`	`881`	`esp_mqtt_client_stop(client);`
`882`	`882`	`}`
`883`	`883`	`esp_mqtt_destroy_config(client);`