mdns: fix malfuctional query_txt

david-cermak · suren-gabrielyan-espressif · commit 90e4babc6170 · 2022-05-27T17:44:22.000+04:00
when running a query for a single txt, result entries were not created and attached to result structure. this issue was introduced when fixing memory leak in txt structure, which worked correctly for PTR queries, but caused trouble for TXT query. * Original commit: espressif/esp-idf@1a02773
diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c
@@ -2831,7 +2831,10 @@ void mdns_parse_packet(mdns_rx_packet_t * packet)
                             }
                         }
                     } else {
-                        _mdns_search_result_add_txt(search_result, txt, txt_count, packet->tcpip_if, packet->ip_protocol);
+                        _mdns_result_txt_create(data_ptr, data_len, &txt, &txt_count);
+                        if (txt_count) {
+                            _mdns_search_result_add_txt(search_result, txt, txt_count, packet->tcpip_if, packet->ip_protocol);
+                        }
                     }
                 } else if (ours) {
                     if (parsed_packet->questions && !parsed_packet->probe) {

Original file line number	Diff line number	Diff line change
`@@ -2831,7 +2831,10 @@ void mdns_parse_packet(mdns_rx_packet_t * packet)`
`2831`	`2831`	`}`
`2832`	`2832`	`}`
`2833`	`2833`	`} else {`
`2834`		`- _mdns_search_result_add_txt(search_result, txt, txt_count, packet->tcpip_if, packet->ip_protocol);`
	`2834`	`+ _mdns_result_txt_create(data_ptr, data_len, &txt, &txt_count);`
	`2835`	`+ if (txt_count) {`
	`2836`	`+ _mdns_search_result_add_txt(search_result, txt, txt_count, packet->tcpip_if, packet->ip_protocol);`
	`2837`	`+ }`
`2835`	`2838`	`}`
`2836`	`2839`	`} else if (ours) {`
`2837`	`2840`	`if (parsed_packet->questions && !parsed_packet->probe) {`