Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixups to example code #448

Closed
wants to merge 1 commit into from
Closed

Conversation

KenwoodFox
Copy link

No description provided.

@KenwoodFox KenwoodFox mentioned this pull request Sep 9, 2022
@@ -155,7 +155,7 @@ static camera_config_t camera_config = {

.jpeg_quality = 12, //0-63 lower number means higher quality
.fb_count = 1, //if more than one, i2s runs in continuous mode. Use only with JPEG
.grab_mode = CAMERA_GRAB_WHEN_EMPTY//CAMERA_GRAB_LATEST. Sets when buffers should be filled
// .grab_mode = CAMERA_GRAB_WHEN_EMPTY//CAMERA_GRAB_LATEST. Sets when buffers should be filled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for commenting out this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is not commented out, you get this error when compiling:

...
Compiling .pio/build/esp32cam/FrameworkArduino/Esp.cpp.o
Compiling .pio/build/esp32cam/FrameworkArduino/FunctionalInterrupt.cpp.o
Compiling .pio/build/esp32cam/FrameworkArduino/HardwareSerial.cpp.o
Compiling .pio/build/esp32cam/FrameworkArduino/IPAddress.cpp.o
Compiling .pio/build/esp32cam/FrameworkArduino/IPv6Address.cpp.o
In file included from src/main.cpp:14:0:
src/cameraInit.h:53:18: error: 'CAMERA_GRAB_WHEN_EMPTY' was not declared in this scope
     .grab_mode = CAMERA_GRAB_WHEN_EMPTY // CAMERA_GRAB_LATEST. Sets when buffers should be filled
                  ^
src/cameraInit.h:54:1: error: 'camera_config_t' has no non-static data member named 'grab_mode'
 };
 ^
*** [.pio/build/esp32cam/src/main.cpp.o] Error 1
============================================================================================ [FAILED] Took 1.34 seconds ============================================================================================
make: *** [Makefile:19: build] Error 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the item is in the struct here maybe PIO is using the wrong version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats so odd, i dont have that on mine
image
and my pio is set to use the latest version

...
lib_deps =                              ; External libraries
  esp32-camera                          ; https://github.com/espressif/esp32-camera
...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the pio registry, its out of date: https://registry.platformio.org/libraries/espressif/esp32-camera

@github-actions
Copy link

This pull request appears to be stale. Please close it if its no longer valid.

@KenwoodFox
Copy link
Author

Still working on this pr, waiting for feedback, keep it open ill test latest ASAP

@github-actions
Copy link

This pull request appears to be stale. Please close it if its no longer valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants