-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tinyusb_driver_uninstall to tinyusb.c (IEC-41) #229
Conversation
@johnboiles thank you very much for the PR, we will review ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnboiles The changes LGTM!
Unfortunately, there is a conflict in usb/esp_tinyusb/include/tusb_cdc_acm.h
could you please rebase your PR? And also check the nitpick from pre-commit about code format, thanks!
0105f93
to
b9d020a
Compare
Done! |
b9d020a
to
bfc399c
Compare
Thank you very much @johnboiles ! Merged. We will release new version of |
Woohoo! Thanks @tore-espressif ! |
This makes it possible for user code to work around the bug where the USB/JTAG interface cannot be re-initialized after calling
tinyusb_driver_install
even if the chip is restarted withesp_restart
(espressif/esp-idf#9826 (comment)).Currently user code cannot do this without a modification to
tinyusb.c
since there's no way to accessstatic usb_phy_handle_t phy_hdl;
outside of that file.With this change, user code can run the following to deactivate TinyUSB and bring back the USB/JTAG interface.