-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCM packaging fixes #131
PCM packaging fixes #131
Conversation
Actually, the work isn't quite done. The CI pipeline wants to validate every version, but will fail for the same reasons on 2.0.0 to 2.0.4. Additionally, here is the more complete error log (of the latest version only):
Proposal: I'm not sure about the 3D models at the moment. |
Hi @JarrettR, thank you for your contribution. We can remove the old versions from the metadata or we can backport the changes, but I don't think this extra work will be needed. |
Okay, I would expect this one to work on the next release. I've removed the metadata file as discussed. Your GH action will regenerate it on release. The other issue is that the KiCad CI pipeline requires 3D models to have a lowercase extensions. Because many of the CAD options seem to prefer uppercase extensions, I submitted a merge request to change that requirement, but it doesn't seem like that will be accepted at this time. So, the STEP extensions in this repo must be lowercase. |
@JarrettR, in order to avoid any confusion with the naming convention, we can change the file names to lowercase on our side. I don't think it will be necessary the MR you proposed. |
This reverts commit 22031c8.
👍 |
When trying to submit this to the official KiCad PCM, the CI pipeline fails. This PR should fix that.
/
from the metadata filenameresources
intodocs
insteadREADME
to reflect the new image locationsThe next release should fix the build zip and we should be able to merge into the PCM