Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rebble] implemented widget_utils #2227

Merged
merged 2 commits into from
Nov 4, 2022
Merged

[Rebble] implemented widget_utils #2227

merged 2 commits into from
Nov 4, 2022

Conversation

Rarder44
Copy link
Contributor

@Rarder44 Rarder44 commented Nov 4, 2022

@Rarder44
implemented widget_utils
ba028e1
@Rarder44
changed the launch.json file name in iconlaunch.json ( launch.cache.j…
adc59dc 
…son -> iconlaunch.cache.json)

 used Object.assing for the settings
 fix cache not deleted when "showClocks" options is changed
 added timeOut to return to the clock
@Rarder44 Rarder44 changed the title implemented widget_utils [Rebble] implemented widget_utils Nov 4, 2022
@Rarder44
Copy link
Contributor Author

Rarder44 commented Nov 4, 2022

I had done this pr for rebble and then I did a commit for iconlauncher;
I wanted to do a separate pr but I find them all here 2.
is that a problem?

@gfwilliams
Copy link
Member

That's fine - thanks! Usually two PRs would be preferable but when you make a PR in GitHub it's based on your current branch - so if you're using master and then you make more changes, those appear too

@gfwilliams gfwilliams merged commit 0b9e511 into espruino:master Nov 4, 2022
@Rarder44 Rarder44 mentioned this pull request Dec 2, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rarder44 @gfwilliams