Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function signature for sensitivityCalculation #623

Open
PavelBal opened this issue Apr 9, 2024 · 2 comments · May be fixed by #731
Open

Function signature for sensitivityCalculation #623

PavelBal opened this issue Apr 9, 2024 · 2 comments · May be fixed by #731
Assignees

Comments

@PavelBal
Copy link
Member

PavelBal commented Apr 9, 2024

Define inputs and outputs.

@Laura-Villain
Copy link

sensitivityCalculation(
simulation,
outputPaths,
parameterPaths,
variationRange = list(range1,range2), (same size than parameterPaths)
variationType = list("absolute","relative"), (same size than parameterPaths)
pkParameters = list("C_max", "t_max", "AUC_inf", "my function" = function), (warning: must be a named list)
saOutputFilePath = NULL,
simulationRunOptions = NULL
)

@PavelBal
Copy link
Member Author

Is variationRange a list of numeric vectors, e.g., list(c(0.5, 1, 2), c(1,2,3))? Does this mean that different variation parameters might have different variation ranges? Yes, doable, we can support this. We should pay attention to how this will be represented in the plots.

Then it should be possible to provide one vector that will be applied to all parameters. So variationRange = c(1,2,3) means that this varation range (or absolute values) will be applied for all parameters. Otherwise, variationRange must be of the same length as parameterPaths.

Same applies to variationType.

Use ospsuite.utils::toList to ensure that variationRange and variationType are lists (and check for their length).

I propose to have the custom functions not as part of the pkParameters argument (because the function is not a PK-parameter), but as a separate argument customOutputFunctions = NULL. Must be a named list (check for names), each group entry must be a function with arguments SimulationResults, outputPaths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants