-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing loaded transformation issue #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#498 - The |
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 83.14% 83.21% +0.07%
==========================================
Files 51 51
Lines 3678 3700 +22
==========================================
+ Hits 3058 3079 +21
- Misses 620 621 +1
|
rerpha
changed the title
Fixing loaded transformation issue (WIP)
Fixing loaded transformation issue
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Relates to #498
Description of work
Cleaning up the code a bit.
Adding
dependee_of
attribute when files are loaded (from json or nexus)Acceptance Criteria
What you have changed, how the reviewer should test it
UI tests
No UI Changes
Nominate for Group Code Review