Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing loaded transformation issue #512

Merged
merged 14 commits into from
Nov 5, 2019
Merged

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Nov 1, 2019

Issue

Relates to #498

Description of work

Cleaning up the code a bit.
Adding dependee_of attribute when files are loaded (from json or nexus)

Acceptance Criteria

What you have changed, how the reviewer should test it

UI tests

No UI Changes

Nominate for Group Code Review

  • Nominate for code review

@rerpha
Copy link
Contributor Author

rerpha commented Nov 1, 2019

#498 - The dependee_of attribute is not getting populated hence why no transformations are showing up. We will need to add this when opening a nexus file or a filewriter command

@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #512 into master will increase coverage by 0.07%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   83.14%   83.21%   +0.07%     
==========================================
  Files          51       51              
  Lines        3678     3700      +22     
==========================================
+ Hits         3058     3079      +21     
- Misses        620      621       +1
Impacted Files Coverage Δ
nexus_constructor/transformation_view.py 31.57% <0%> (-0.68%) ⬇️
nexus_constructor/component_tree_view.py 24.65% <0%> (-0.35%) ⬇️
nexus_constructor/component/component.py 96.25% <100%> (+0.04%) ⬆️
...ctor/geometry/disk_chopper/disk_chopper_checker.py 100% <100%> (ø) ⬆️
nexus_constructor/nexus/nexus_wrapper.py 92.57% <100%> (+2.19%) ⬆️
nexus_constructor/transformations.py 96.39% <80%> (-0.86%) ⬇️
nexus_constructor/component_tree_model.py 88.13% <92.85%> (ø) ⬆️

@rerpha rerpha marked this pull request as ready for review November 5, 2019 14:39
@rerpha rerpha added bug Something isn't working high priority labels Nov 5, 2019
@rerpha rerpha changed the title Fixing loaded transformation issue (WIP) Fixing loaded transformation issue Nov 5, 2019
@rerpha rerpha merged commit 820c6c3 into master Nov 5, 2019
@rerpha rerpha deleted the 498_fix_loaded_transformations branch November 5, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants