Get field value fix #759
Merged
Get field value fix #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerpha
reviewed
Jun 2, 2020
matthew-d-jones
suggested changes
Jun 2, 2020
matthew-d-jones
approved these changes
Jun 2, 2020
rerpha
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sorts out the field value issue.
Description of work
Restored the original
get_field_valuebehaviour and created a test for it. Also extracted_get_shape_group_for_pixel_dataand gave it a doc string.Acceptance Criteria
Check that the tests pass.
UI tests
n/a
Nominate for Group Code Review