Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get field value fix #759

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Get field value fix #759

merged 8 commits into from
Jun 2, 2020

Conversation

DolicaAkelloEgwel
Copy link
Contributor

@DolicaAkelloEgwel DolicaAkelloEgwel commented Jun 2, 2020

Issue

Sorts out the field value issue.

Description of work

Restored the original get_field_value behaviour and created a test for it. Also extracted _get_shape_group_for_pixel_data and gave it a doc string.

Acceptance Criteria

Check that the tests pass.

UI tests

n/a

Nominate for Group Code Review

  • Nominate for code review

@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review June 2, 2020 11:34
tests/test_group.py Outdated Show resolved Hide resolved
nexus_constructor/model/component.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matthew-d-jones matthew-d-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to add.

nexus_constructor/model/component.py Outdated Show resolved Hide resolved
@rerpha rerpha merged commit dd19600 into model_change Jun 2, 2020
@rerpha rerpha deleted the get_field_value_fix branch June 2, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants