Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

771: Edited component loses transformations #776

Merged
merged 3 commits into from
Jun 12, 2020
Merged

771: Edited component loses transformations #776

merged 3 commits into from
Jun 12, 2020

Conversation

DolicaAkelloEgwel
Copy link
Contributor

@DolicaAkelloEgwel DolicaAkelloEgwel commented Jun 11, 2020 •
edited
Loading

Issue

Closes #771

Description of work

Should fix the issue of transformations disappearing when a component is edited. Also added some tests to check for the transformation changed signal being emitted.

Acceptance Criteria

  1. Create a component
  2. Add a transformation
  3. Edit the component
  4. Check that the transformations are preserved

UI tests

n/a

Nominate for Group Code Review

  • Nominate for code review

@DolicaAkelloEgwel DolicaAkelloEgwel changed the base branch from master to model_change June 11, 2020 15:50
@DolicaAkelloEgwel DolicaAkelloEgwel changed the title 771 edited component loses transformations 771: Edited component loses transformations Jun 11, 2020
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review June 12, 2020 07:35
matthew-d-jones
matthew-d-jones approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@matthew-d-jones matthew-d-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Good tests, and functions as expected.

@matthew-d-jones matthew-d-jones merged commit 7e46e5d into model_change Jun 12, 2020
@matthew-d-jones matthew-d-jones deleted the 771_edited_component_loses_transformations branch June 12, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-d-jones matthew-d-jones matthew-d-jones approved these changes

@rerpha rerpha Awaiting requested review from rerpha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After editing component it is rendered without transformations
2 participants
@DolicaAkelloEgwel @matthew-d-jones