Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting started README #846

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Update Getting started README #846

merged 2 commits into from
Mar 12, 2021

Conversation

ebadkamil
Copy link
Contributor

Update the getting started readme since Nexus File Layout tab does not exist in latest version.

@mattclarke
Copy link
Member

What are these images? Are they supposed to be empty files?

@ebadkamil
Copy link
Contributor Author

ebadkamil commented Mar 2, 2021

I updated the screenshots too with the latest ones that I took today.

@codecov-io
Copy link

Codecov Report

Merging #846 (b2bed05) into main (da9b09b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          57       57           
  Lines        4535     4535           
=======================================
  Hits         3847     3847           
  Misses        688      688           

@ebadkamil ebadkamil requested a review from kmurica March 3, 2021 07:52
@ebadkamil
Copy link
Contributor Author

ebadkamil commented Mar 9, 2021

When we set translation to +2 in z direction (0, 0, 1) why the sample is deliberately moved to 2m in -ve z direction?

transform.setTranslation(self.vector.normalized() * -1 * self.ui_value)

Does it have something to do with the direction of beam? @kmurica

nexus

@kmurica
Copy link
Contributor

kmurica commented Mar 11, 2021

When we set translation to +2 in z direction (0, 0, 1) why the sample is deliberately moved to 2m in -ve z direction?

transform.setTranslation(self.vector.normalized() * -1 * self.ui_value)

Does it have something to do with the direction of beam? @kmurica

Just to document it here: the passive transformation is actually moving the coordinate system and not the object. In that case, moving the origo 2 units in (0, 0, 1) direction, would redefine all objects' z-coordinate by -2.

Copy link
Contributor

@kmurica kmurica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kmurica kmurica merged commit 48147d5 into main Mar 12, 2021
@kmurica kmurica deleted the getting_started_read branch March 12, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants