Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX issues Mac (Firefox and Chrome/Brave) #48

Closed
5 tasks done
sharon-wang opened this issue Jun 13, 2020 · 3 comments
Closed
5 tasks done

UI/UX issues Mac (Firefox and Chrome/Brave) #48

sharon-wang opened this issue Jun 13, 2020 · 3 comments
Labels
bug Something isn't working GftW x DEV Hackathon Part of our hackathon prototype

Comments

@sharon-wang
Copy link
Member

sharon-wang commented Jun 13, 2020

Related: #41

The following issues were found during testing in Firefox and Chrome/Brave on Mac.

  • Empty circle space should be filled with something

image

  • Should never display 'NaN'

image

Moved to #54
- [ ] Circle shouldn't be empty
- [ ] Favicon loading issue? Image stretched

  • Text in circle too small, not easily legible
    image

  • Mismatched favicon & Empty circle due to no favicon and circle too small for text display
    image

Moved to #55.
- [ ] icon pic in tutorial doesn't match the icon badge in firefox

  • handle single visit/minute/etc, i.e. "1 visits" --> "1 visit"; "1 minutes" --> "1 minute", etc.
@sharon-wang sharon-wang added the GftW x DEV Hackathon Part of our hackathon prototype label Jun 13, 2020
sharon-wang added a commit that referenced this issue Jun 13, 2020
Fix various bugs discovered in #48 testing
@sharon-wang sharon-wang added the bug Something isn't working label Jun 13, 2020
@sharon-wang
Copy link
Member Author

sharon-wang commented Jun 13, 2020

  • Resources cut off in Brave on Mac

image

The spacing issue is resolved once a monetized site is visited
image

"These sites could use some <3" should not be displayed if a user is not using a monetization provider

@vezwork
Copy link
Member

vezwork commented Jun 13, 2020

image
Websites without favicons are not properly indented in the sites that need love section.

@sharon-wang
Copy link
Member Author

image
Websites without favicons are not properly indented in the sites that need love section.

This problem has been added to issue #78.

This issue is complete - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GftW x DEV Hackathon Part of our hackathon prototype
Projects
None yet
Development

No branches or pull requests

2 participants