Fix favicon loading blocking popup opening by lazy-loading favicons #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vezwork
changed the title
vezwork
force-pushed
the
faviconloading
branch
from
006a9f7
to
347068f
Compare
2 tasks
sharon-wang
approved these changes
Dec 23, 2020
vezwork
force-pushed
the
faviconloading
branch
from
347068f
to
f702aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the user experience problem in issue #54. We could still improve favicon loading time by caching the top favicons, but it's no longer a significant UX issue.
The Problem:
The browser waits for favicon images to load before opening the extension popup. This behavior results in the popup taking a while to open if the favicons take a while to load.
The solution:
Favicon images are
fetchedbefore being put into image elements on the page (lazy-loaded images). This prevents the browser for waiting for image elements to load.