-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random horse coloration added to MobData - "mixed" #556
base: 2.x
Are you sure you want to change the base?
Conversation
Cleanup ess cleanup timestamp matching
…w. [EXPERIMENTAL]
…warning' set in ms not ns.
Permission: essentials.mute.offline
Permission: essentials.feed.cooldown.bypass
Clean up info file handling
…kkit.yml aliases to make custom commands.
…scaping in ingame chat Other formatting class cleanup
Replace <none> with what you want to show if there are no players from that group online.
…to combat slow SQL economies. This option is not recommended under normal circumstances.
Fixes ESS-4690
This runs before the pager, so keywords on other pages will still be parsed.
we already use the phrase 'random' for random colours like sheep, bad idea for a new convention. |
I assume this means your preference is to incorporate it into the 'random' phrase. The only reason why I created a new convention is random is tightly coupled to the sheep entity in the code, and horses needed both color and style variation. Let me know. I am sure it can be adjusted to use 'random' and the colorable constant. |
It looks like the whole horse enumeration part needs to be reworked. I see 23 varieties listed out of 32 and I am not sure all of these would work. I can propose a clean-up of the horse part of the enum and take a look at using the 'random' phrase for horses. If you are not already looking into it, let me know and I will knock it out. |
Feel free, no one is currently working on this code. |
Added "mixed" to MobData to handle random color and style for horses.