Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random horse coloration added to MobData - "mixed" #556

Open
wants to merge 3,961 commits into
base: 2.x
Choose a base branch
from

Conversation

FIlchersSoup
Copy link

Added "mixed" to MobData to handle random color and style for horses.

khobbits and others added 30 commits May 4, 2013 19:22
Cleanup ess cleanup timestamp matching
khobbits and others added 25 commits August 18, 2013 21:02
Permission: essentials.mute.offline
Permission: essentials.feed.cooldown.bypass
…scaping in ingame chat Other formatting class cleanup
Replace <none> with what you want to show if there are no players from that group online.
…to combat slow SQL economies.

This option is not recommended under normal circumstances.
This runs before the pager, so keywords on other pages will still be parsed.
@khobbits
Copy link
Member

khobbits commented Sep 1, 2013

we already use the phrase 'random' for random colours like sheep, bad idea for a new convention.

@FIlchersSoup
Copy link
Author

I assume this means your preference is to incorporate it into the 'random' phrase. The only reason why I created a new convention is random is tightly coupled to the sheep entity in the code, and horses needed both color and style variation.

Let me know. I am sure it can be adjusted to use 'random' and the colorable constant.

@FIlchersSoup
Copy link
Author

It looks like the whole horse enumeration part needs to be reworked. I see 23 varieties listed out of 32 and I am not sure all of these would work. I can propose a clean-up of the horse part of the enum and take a look at using the 'random' phrase for horses. If you are not already looking into it, let me know and I will knock it out.

@khobbits
Copy link
Member

khobbits commented Sep 4, 2013

Feel free, no one is currently working on this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.