Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor query execution #25

Merged
merged 3 commits into from
May 21, 2024
Merged

Refactor query execution #25

merged 3 commits into from
May 21, 2024

Conversation

tamaroning
Copy link
Collaborator

@tamaroning tamaroning commented May 16, 2024 •
edited
Loading

depends on #24

Add QueryExecutor to fetch a chunk asynchronously.

@tamaroning tamaroning force-pushed the feat/fetch-on-demand branch 3 times, most recently from e093526 to c5fcd59 Compare May 17, 2024 05:34
@tamaroning tamaroning changed the title WIP refactor Refactor query execution May 17, 2024
@tamaroning tamaroning marked this pull request as ready for review May 17, 2024 05:41
kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
tests/test-async.rs Outdated Show resolved Hide resolved
kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
src/row.rs Outdated Show resolved Hide resolved
kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
tests/test-chunk.rs Outdated Show resolved Hide resolved
kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
src/query.rs Outdated Show resolved Hide resolved
@kenkoooo kenkoooo mentioned this pull request May 17, 2024
Merged
@tamaroning
Copy link
Collaborator Author

Fixed.
Squashed all commits to the last one

kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
src/query.rs Outdated Show resolved Hide resolved
kenkoooo
kenkoooo reviewed May 17, 2024
View reviewed changes
src/query.rs Outdated Show resolved Hide resolved
@tamaroning
Copy link
Collaborator Author

Rebased and added tests

kenkoooo
kenkoooo approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@kenkoooo kenkoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@kenkoooo kenkoooo merged commit c310c5b into estie-inc:main May 21, 2024
0 of 6 checks passed
@kenkoooo
Copy link
Member

The changes have been shipped as version 0.3.0. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenkoooo kenkoooo kenkoooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamaroning @kenkoooo