-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Process ID to PatternEncoder #91
Conversation
75d4874
to
e2d9f17
Compare
I'm not sure what the issue is here, but it seems related to CircleCI pinning the Rust version on a version before the introduction of |
@naftulikay I like this! In my open pr I've updated the rust build version 1.38 and it seems to be working. Would you back out the edition commit and we'll see if we can get this merged? |
@estk I have removed the edition change as requested 👍 |
@naftulikay great, I'm waiting on a review of #92 in order to get CI working again. Would you give it a look? After CI is fixed and this is re-run I'll merge. |
@estk sure, are you looking for a review? seems like a massive amount of changes, though I'm grateful for all the hard work! |
@naftulikay ok, now that that is out of the way, can you rebase and rustfmt? |
76368c1
to
52ca9c3
Compare
@estk rebased, do note that |
@naftulikay thanks a million! |
Did a review (a little bit late ;) ). Change looks perfect, thanks to all for landing that! |
Allow specifying the process ID in
PatternEncoder
for including the current process ID in log formats.