Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemalate/firebolt: support arrays #421

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 25, 2022

Description:

  • Support arrays in materialize-firebolt
  • Arrays will be saved as ARRAY(<INNER_TYPE>) on Firebolt (this includes nested arrays, so ARRAY(ARRAY(STRING)) is also valid)

Workflow steps:

Include an array field in field selection of a materialization, i.e.:

        nested_array:
          type: array
          description: a nested array
          items:
            type: array
            items:
              type: string
  acmeCo/firebolt/materialize-file-sizes:
    endpoint:
      flowSink:
        image: docker.io/library/materialize-firebolt:local
        config: acmeCo/materialize-firebolt.config.yaml
    bindings:
      - resource:
          table: files
          table_type: fact
        source: acmeCo/file-sizes
        fields:
          recommended: true
          include: { nested_array: {} } # <-------------

Documentation links affected:

N/A

Notes for reviewers:

This is what it looks like in Firebolt:
image
image


This change is Reviewable

@mdibaiee mdibaiee force-pushed the mahdi/firebolt-array-object branch 2 times, most recently from 78ab646 to f86d699 Compare March 28, 2022 08:20
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdibaiee mdibaiee merged commit f9280c3 into master Mar 29, 2022
@mdibaiee mdibaiee deleted the mahdi/firebolt-array-object branch March 29, 2022 13:31
@oliviamiannone oliviamiannone added the docs complete / NA No (more) doc work related to this PR label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs complete / NA No (more) doc work related to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants