This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
refactors for model cleanups and control-plane builds #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are being removed from the flow tree, as they're now connectors.
Refactor catalog database loading into routines which use the built databases as a primary representation, so that callers can pick and choose which representations and specifications they care to load. CatalogTask and CatalogCommons are removed. A `Task` interface is introduced which the relevant types now implement, to simpify unified handling of task variants. Where other types previously referenced a CatalogCommons and revision, they now reference a Build ID: a unique identifier for a built catalog database. TestSpec no longer inlines collection attributes, as they were both insufficient (missing partition information) and are now resolved directly from the catalog database under test. Remove protobuf fields from RangeSpec that prevent native Go equality from working. Update BuildAPI.Config to expect a passed Build ID, and tweak its `directory` semantics (dropping `catalog_path`). Remote Splitter service, as this workflow is now expressed through the existing Shard.Apply RPC. (Re-)add a Testing service which surfaces reactor functionality needed only while running tests. The Ingest service is removed, but a test-specific Ingest RPC is added. We'll probably bring an ingestion service back in a different form, in the near future. Issue estuary/flow#276
|
I've gone ahead and merged, but please do still review and I'll address any feedback as follow-ups. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.