Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking what payment provider tenant is using before warning payment methods #785

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Checking what payment provider tenant is using before warning payment methods #785

merged 7 commits into from
Oct 11, 2023

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Oct 11, 2023 •
edited
Loading

Adding the types for that
Checking the new column to see if we need to fetch payment methods

Issues

#784

Changes

784

  • Added a new column to fetch from tenants
  • Skip the call for payment methods for tenants that pay externally

Misc

  • Stop fetching payment methods if there is no trial started
  • Replaced checking all tenants with checking all payment methods so we do not scare users

Tests

Manually tested

  • Added the column manually and tested against it

Screenshots

N/A

All external means no calls to billing to get payment methods
image
image

2 in stripe means two calls
image
image
image

2 in stripe but not in trial means no calls
image
image

@travjenkins
Copy link
Member Author

This depends on estuary/flow#1232 being completed first

@travjenkins travjenkins changed the title Adding the new column for checking if a customer uses external payment Checking what payment provider tenant is using before warning payment methods Oct 11, 2023
@travjenkins travjenkins marked this pull request as ready for review October 11, 2023 15:57
@travjenkins travjenkins requested a review from a team as a code owner October 11, 2023 15:57
jshearer
jshearer approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after estuary/flow#1232 is merged

@travjenkins travjenkins merged commit 65720f8 into main Oct 11, 2023
3 checks passed
@travjenkins travjenkins deleted the travjenkins/checkIfCustomersPayExternally branch October 11, 2023 18:39
@travjenkins travjenkins mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshearer jshearer jshearer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @jshearer