Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify import syntax #35

Merged
merged 1 commit into from
Oct 12, 2020
Merged

doc: clarify import syntax #35

merged 1 commit into from
Oct 12, 2020

Conversation

hamzahamidi
Copy link
Contributor

No description provided.

nebrelbug
nebrelbug approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@nebrelbug nebrelbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great.

@nebrelbug nebrelbug merged commit 1affb7d into eta-dev:master Oct 12, 2020
@nebrelbug
Copy link
Collaborator

@hamzahamidi do you mind if I add you to the README as a contributor?

@hamzahamidi
Copy link
Contributor Author

hamzahamidi commented Oct 12, 2020 •
edited
Loading

@nebrelbug Yeah sure. Great Lib btw. I came across it thanks to docusaurus.

@hamzahamidi hamzahamidi deleted the patch-1 branch October 12, 2020 22:33
@nebrelbug
Copy link
Collaborator

@hamzahamidi thank you! I'm glad you like the library.

@all-contributors please add @hamzahamidi for documentation 🎉

@allcontributors allcontributors bot mentioned this pull request Oct 12, 2020
Merged
@allcontributors
Copy link
Contributor

@nebrelbug

I've put up a pull request to add @hamzahamidi! 🎉

@nebrelbug
Copy link
Collaborator

@hamzahamidi just added you to the README :)

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebrelbug nebrelbug nebrelbug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamzahamidi @nebrelbug