Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genemetrics maybe have bugs in 0.9.7 #573

Closed
diushiguzhi opened this issue Feb 24, 2021 · 1 comment · Fixed by #580
Closed

genemetrics maybe have bugs in 0.9.7 #573

diushiguzhi opened this issue Feb 24, 2021 · 1 comment · Fixed by #580

Comments

@diushiguzhi
Copy link

Hi,
when I use genemetrics with cnvkit 0.9.7 , the variants are disappeared, which can be detected with cnvkit 0.9.6.

Then I check the scripts, the differents as follows :
a. The function "as_dataframe" in skgenome/gary.py is different between 0.9.7 and 0.9.6
b. In 0.9.6 the dataframe index is reset,which is not reset by default in 0.9.7
c. So the script of function "by_gene" in cnary.py "yield gene, subgary.as_dataframe(subgary.data.iloc[start_idx:end_idx])" return the none

@eriktoo
Copy link

eriktoo commented Mar 16, 2021

Hi Diushiguzhi,

Take a look at my comments, especially the latest one, on the issue linked below. I think I found a bug in the way by_gene() handles arrays which was in my case yielding None type arrays. I include a fix that seems to work for me.

#576

Thanks,
Erik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants