Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.12.2 et transport-tools 1.0.3 #39

Conversation

AntoineAugusti
Copy link
Member

@AntoineAugusti AntoineAugusti commented Feb 23, 2022

Notes Thibaut

Notes Antoine précédentes

Sans le bump introduit dans #33

Mais avant comme base la release d'avant https://github.com/etalab/transport-ops/releases/tag/elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.2 utilisée sur master https://github.com/etalab/transport-site/blob/8e243e06f26c7d7c5429c4c49b1b19855eb25d6f/Dockerfile#L1

La version serait alors elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.3

thbar and others added 2 commits February 9, 2022 16:09
* Make sure the docker hub link is closer from the image

* Update to most recent elixir/erlang couple

* Bump NVM to latest

https://github.com/nvm-sh/nvm/releases

* Bump NodeJS to latest LTS available

https://nodejs.org

* Try to fix the build

* Update test for NodeJS

* Update test for Elixir version

* Modify script to make it work with newer format

* Add readme test to verify OTP version in full (improved)

* Update GitHub action to assert on full version

* Now use full version specifier

* Add explanation about how the hex images are built

* Add very useful help to see output of commands locally

The CI already does that by default.

* Upgrade packages (except kernel) for security

See etalab/transport-deploy#46 for context

* Bump to latest

* Bump Node to latest LTS

* Bump tests
@AntoineAugusti
Copy link
Member Author

La tâche Rake ne semble plus donner le bon nom de version, elle ne prend pas transport-tools.

@thbar thbar changed the base branch from master to elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.x February 24, 2022 13:11
@thbar
Copy link
Contributor

thbar commented Feb 24, 2022

J'ai créé une branche de maintenance en partant du tag utilisé en production actuellement:

https://github.com/etalab/transport-site/blob/4d36a687f13bbd94e5414f7ecd0b7d74674a9f59/Dockerfile#L1

comme suit:

git checkout -b elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.x elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.2

Puis j'ai ciblé cette branche dans la PR.

@thbar
Copy link
Contributor

thbar commented Feb 24, 2022

Je vais merger dans la branche de maintenance, et créer une release à partir de là, et on sera bon je pense.

@thbar thbar merged commit 75d95c6 into elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.x Feb 24, 2022
@thbar thbar deleted the elixir-1.12.2-transport-tools-1.0.3 branch February 24, 2022 13:18
@thbar
Copy link
Contributor

thbar commented Feb 24, 2022

Je crée un ticket pour backporter dans master (#40).

AntoineAugusti added a commit to etalab/transport-site that referenced this pull request Feb 24, 2022
* Work on GTFSRTValidationDispatcherJob

* Work on main job

* Work on convert_report

* Save to database

* Write success test

* Add another GTFS-RT file

* Add validation logs

* Try updated Dockerfile

* Update validator path

* Add bang

* Use maintenance release

See:
- https://github.com/etalab/transport-ops/releases/tag/elixir-1.12.2-erlang-24.0.4-ubuntu-focal-20210325-transport-tools-1.0.3
- etalab/transport-ops#39
thbar added a commit that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants