Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to unspam discussion and message #352

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

ThibaudDauce
Copy link
Contributor

Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, this is working great !

Do we want to change the Thread or comment style when it's marked as spam ? Or is the button enough for moderators ?

Can you add a .stories.ts and a .mdx files too ?

Can you rename the folder to MarkAsNoSpam to match existing ones?

@ThibaudDauce
Copy link
Contributor Author

Thanks for this PR, this is working great !

Do we want to change the Thread or comment style when it's marked as spam ? Or is the button enough for moderators ?

I don't know, we can start with this and update it in the future if we think it's too soft?

Can you add a .stories.ts and a .mdx files too ?

How do you create the stories.ts and the mdx files?

Can you rename the folder to MarkAsNoSpam to match existing ones?

For the folder, do you want me to rename spam to Spam or to MarkAsNoSpam (I named it spam because I think we may have more components in the future than just this one)

@nicolaskempf57
Copy link
Contributor

I don't know, we can start with this and update it in the future if we think it's too soft?

Yes !

How do you create the stories.ts and the mdx files?

There is no automation to create it, so they must be done manually. There is a MDX plugin for VSCode to add colors. My links to the existing example were not working so here they are again :

For the folder, do you want me to rename spam to Spam or to MarkAsNoSpam (I named it spam because I think we may have more components in the future than just this one)
I think you can name it MarkAsNoSpam. When we will add other components, we can make the a folder for each component and the Spam folder as parent.

Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Only some minor changes left

ThibaudDauce and others added 2 commits February 13, 2024 12:01
…kAsNoSpam.stories.ts

Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
…kAsNoSpam.vue

Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
…kAsNoSpam.vue

Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me !

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we can start with this layout, we'll improve if needed :)

Don't forget the changelog ;)

@ThibaudDauce ThibaudDauce merged commit 473f858 into master Feb 15, 2024
5 of 7 checks passed
@maudetes maudetes deleted the improved_spam_prevention branch February 15, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants