-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to unspam discussion and message #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, this is working great !
Do we want to change the Thread or comment style when it's marked as spam ? Or is the button enough for moderators ?
Can you add a .stories.ts
and a .mdx
files too ?
Can you rename the folder to MarkAsNoSpam
to match existing ones?
udata_front/theme/gouvfr/assets/js/components/spam/MarkAsNoSpam.vue
Outdated
Show resolved
Hide resolved
I don't know, we can start with this and update it in the future if we think it's too soft?
How do you create the stories.ts and the mdx files?
For the folder, do you want me to rename |
Yes !
There is no automation to create it, so they must be done manually. There is a MDX plugin for VSCode to add colors. My links to the existing example were not working so here they are again :
|
c05c535
to
275117b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Only some minor changes left
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.stories.ts
Outdated
Show resolved
Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.vue
Outdated
Show resolved
Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.vue
Show resolved
Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.stories.ts
Show resolved
Hide resolved
…kAsNoSpam.stories.ts Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.vue
Outdated
Show resolved
Hide resolved
…kAsNoSpam.vue Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
udata_front/theme/gouvfr/assets/js/components/MarkAsNoSpam/MarkAsNoSpam.vue
Outdated
Show resolved
Hide resolved
…kAsNoSpam.vue Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think we can start with this layout, we'll improve if needed :)
Don't forget the changelog ;)
Link with opendatateam/udata#2954