Limit cache size #23
Merged
Limit cache size #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initializing the backend in the global memory pool creates an unneccessary amount of coupling, which this patch removes
also make it possible to set the desired memory size for ArgoDSM using an environment variable, but prefer a parameter given to argo::init() for backwards compatibility.
pekemark
reviewed
Oct 4, 2019
SakalisC
previously approved these changes
Oct 4, 2019
pekemark
reviewed
Oct 4, 2019
pekemark
reviewed
Oct 4, 2019
pekemark
reviewed
Oct 4, 2019
pekemark
reviewed
Oct 4, 2019
pekemark
requested changes
Oct 4, 2019
The name "size" is too generic. Co-authored-by: David Klaftenegger <david.klaftenegger@it.uu.se> Co-authored-by: Magnus Norgren <magnusandersnorgren@gmail.com>
The cache size is exposed to a second parameter to argo::init() and argo_init(). Instead of setting the value explicitly, it can also be controlled through environment variable ARGO_CACHE_SIZE. If neither the parameter nor ARGO_CACHE_SIZE are set, then the default is a 1GB cache. Co-authored-by: David Klaftenegger <david.klaftenegger@it.uu.se> Co-authored-by: Magnus Norgren <magnusandersnorgren@gmail.com>
davidklaftenegger
force-pushed
the
cache_size
branch
from
32bbf41
to
7d2d3c7
Compare
pekemark
approved these changes
Oct 4, 2019
SakalisC
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #19, which I accidentally broke.
This patch contains several commits:
d5b1670 gives the responsibility of initialising everything to argo::init()
32cbb09 adds the option to use an environment variable to set the memory size used
3187658 only renames arguments from size to argo_size
f08ae31 limits the cache size to a value also optionally set through argo::init() or an environment variable
32bbf41 limits the cache size to the total memory size, if it is smaller than the requested memory size
The main changes in 3187658 and f08ae31 are taken from #14, but split into two commits for readability.
Note that this pull request does not contain all features from #14, as it only deals with commit
60e68ce.