Send emails asynchronously #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocj89
force-pushed
the
pu/mail-async
branch
2 times, most recently
from
7520579
to
566c147
Compare
Merged
mariocj89
force-pushed
the
pu/mail-async
branch
from
566c147
to
bc896f5
Compare
|
This works. I rebased and added some fixes so that it works with Celery 5 here: https://github.com/etcaterva/eas-backend/tree/pedro/async-emails Also, there's this issue that would be nice to fix in the future, to have a nicer way of doing local development with docker-compose: #127 |
|
What do we need for this to be released? We need to change our email backend isn't it? |
mariocj89
force-pushed
the
pu/mail-async
branch
3 times, most recently
from
da1e1d3
to
7135556
Compare
palvarez89
reviewed
Oct 30, 2021
mariocj89
force-pushed
the
pu/mail-async
branch
from
7135556
to
487afc8
Compare
palvarez89
approved these changes
Oct 31, 2021
Use celery to send emails asyncronously. This will allow to handle secret santa draws with a high number of participants. Without this, the server waits synchronously for the emails to be sent, timesouts and harakiri will finalize the web backend process.
mariocj89
force-pushed
the
pu/mail-async
branch
from
487afc8
to
251ac30
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use celery to send emails asyncronously. This will allow to handle
secret santa draws with a high number of participants. Without this, the
server waits synchronously for the emails to be sent, timesouts and
harakiri will finalize the web backend process.
Closes #101