Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NoSyncFreelist reachability checking #10

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

heyitsanthony
Copy link
Contributor

  • scan for free pages if freelist page is valid but the db is opened with
    NoSyncFreelist; forces the freelist pages to count as free pages.

  • only treat freelist pages as reachable if set to valid pgid

Fixes #9

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this fixes. LGTM.
/cc @xiang90

@xiang90
Copy link
Contributor

xiang90 commented Aug 8, 2017

lgtm

@heyitsanthony
Copy link
Contributor Author

this was failing on CI because jenkins was misconfigured to run tests against master instead of the current workspace

* unconditionally free freelist, if any, when committing txn

* only treat freelist pages as reachable if set to valid pgid

Fixes boltdb#9
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for the fix!

@heyitsanthony heyitsanthony merged commit b219ffc into etcd-io:master Aug 9, 2017
@heyitsanthony heyitsanthony deleted the fix-freepage-test branch August 9, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants