Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS file for bbolt #569

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add OWNERS file for bbolt #569

merged 1 commit into from
Sep 18, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Sep 16, 2023

Sub-task of etcd-io/etcd#16367.

This pull request proposes a layout for the OWNERS file we need to add to each non archived subproject under the etcd-io github organisation as part of the creation of sig-etcd.

Refer to OWNERS documentation: https://www.kubernetes.dev/docs/guide/owners

Note: Once the sig comes online fully and we shift to managing org membership through the kubernetes org bot then we need to consider a follow-up pull request to prune out the old MAINTAINERS file approach.

@ahrtr
Copy link
Member

ahrtr commented Sep 18, 2023

Thanks @jmhbnz raising this PR.

I suggest to follow the exact list in MAINTAINERS file. As an open source community, let's keep everything as transparent as possible. Promoting anyone should be discussed & agreed firstly, and it should be in a separate & dedicated session.

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz
Copy link
Member Author

jmhbnz commented Sep 18, 2023

I suggest to follow the exact list in MAINTAINERS file. As an open source community, let's keep everything as transparent as possible. Promoting anyone should be discussed & agreed firstly, and it should be in a separate & dedicated session.

Done - Sorry it was unclear to me how separate bbolt is treated from etcd so I had just copied from etcd's file. Thanks for the feedback.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 1105f75 into etcd-io:master Sep 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants