Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advertise client urls accepts empty hosts #8379

Closed
heyitsanthony opened this issue Aug 9, 2017 · 4 comments
Closed

advertise client urls accepts empty hosts #8379

heyitsanthony opened this issue Aug 9, 2017 · 4 comments
Milestone

Comments

@heyitsanthony
Copy link
Contributor

A command line misconfiguration from irc:

$ SPELLEDOK="localhost"
$ etcd --listen-client-urls=http://127.0.0.1:2379 --advertise-client-urls=http://$SPELEDOK:2379 &
$ etcdctl member list
8e9e05c52164694d: name=default peerURLs=http://localhost:2380 clientURLs=http://:2379 isLeader=true

etcd should probably detect empty advertise hostnames and exit with an error.

/cc @kbrwn

@xiang90
Copy link
Contributor

xiang90 commented Oct 27, 2017

/cc @harryge00 would you like to help on this one?

@shubheksha
Copy link

Hi, I'd like to work on this issue if it's not taken already. This would be my first contribution so I'd appreciate some help regarding where to get started. 😄

@gyuho
Copy link
Contributor

gyuho commented Dec 6, 2017

@shubheksha That would be great. Please start from #8384 as reference. And let us know if you need more help.

Thanks!

@xiang90
Copy link
Contributor

xiang90 commented Jan 26, 2018

fixed by #8786

@xiang90 xiang90 closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants